[PATCH] kexec: Increase the upper limit for RAM segments

[Sameer Goel]

Change the current hardcoded values to 64 from 16.

Signed-off-by: Sameer Goel <***@codeaurora.org>
---
kexec/arch/arm64/kexec-arm64.h | 2 +-
kexec/kexec-syscall.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kexec/arch/arm64/kexec-arm64.h b/kexec/arch/arm64/kexec-arm64.h
index bac62f8..bd4c20e 100644
--- a/kexec/arch/arm64/kexec-arm64.h
+++ b/kexec/arch/arm64/kexec-arm64.h
@@ -11,7 +11,7 @@
#include "image-header.h"
#include "kexec.h"

-#define KEXEC_SEGMENT_MAX 16
+#define KEXEC_SEGMENT_MAX 64

#define BOOT_BLOCK_VERSION 17
#define BOOT_BLOCK_LAST_COMP_VERSION 16
diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h
index c0d0bea..f84c937 100644
--- a/kexec/kexec-syscall.h
+++ b/kexec/kexec-syscall.h
@@ -115,7 +115,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd,
#define KEXEC_ARCH_MIPS ( 8 << 16)
#define KEXEC_ARCH_CRIS (76 << 16)

-#define KEXEC_MAX_SEGMENTS 16
+#define KEXEC_MAX_SEGMENTS 64

#ifdef __i386__
#define KEXEC_ARCH_NATIVE KEXEC_ARCH_386

[Geoff Levand]

Hi Sameer.

Post by Sameer Goel
Change the current hardcoded values to 64 from 16.

Please add an explanation of why this change is needed.

-Geoff

[Goel, Sameer]

This change is needed in case when the System Ram listings are retrieved
from /proc/iomem. On a newer UEFI based Qualcomm system, the number of
regions listed were close to 34. So, the actual system ram region was
not covered and the kexec tool failed to load the kernel image.

So, I have requested an increase in the number of memory regions.
Thanks,
Sameer

Post by Geoff Levand
Hi Sameer.

Post by Sameer Goel
Change the current hardcoded values to 64 from 16.

Please add an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
http://lists.infradead.org/mailman/listinfo/kexec

[Baoquan He]

Post by Goel, Sameer
This change is needed in case when the System Ram listings are retrieved
from /proc/iomem. On a newer UEFI based Qualcomm system, the number of
regions listed were close to 34. So, the actual system ram region was not
covered and the kexec tool failed to load the kernel image.
So, I have requested an increase in the number of memory regions.
Thanks,

It would be great to add this to your patch log so that reviewers can
understand it better. Better repost with an updated patch log, copying
these as patch log is good enough.

Post by Goel, Sameer
Sameer

Post by Geoff Levand
Hi Sameer.

Post by Sameer Goel
Change the current hardcoded values to 64 from 16.

Please add an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
http://lists.infradead.org/mailman/listinfo/kexec

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
_______________________________________________
kexec mailing list
http://lists.infradead.org/mailman/listinfo/kexec

[Geoff Levand]

Hi Sameer,

This change is needed in case when the System Ram listings are retrieved from /proc/iomem. On a newer UEFI based Qualcomm system, the number of regions listed were close to 34. So, the actual system ram region was not covered and the kexec tool failed to load the kernel image.
So, I have requested an increase in the number of memory regions.
Thanks,
Sameer

Post by Geoff Levand
Hi Sameer.

Post by Sameer Goel
Change the current hardcoded values to 64 from 16.

Please add an explanation of why this change is needed.

Sorry I wasn't clear. Please post a new patch, and
in the commit log include an explanation of why this
change is needed.

-Geoff