[RFC PATCH 0/4] eppic: Create kernel version compatible scripts

[Atsushi Kumagai]

Hello Kamalesh,

This patch series creates eppic scripts a for range kernel versions
they are compatible with. Eppic scripts directory host sample
scripts to scrub sensitive information from the dump file generated
using makedumpfile.
The initial version of these scripts was based on Fedora 19 kernel.
In brief, these scripts rely on hard coded kernel data structure
member offsets. Kernel data structures are bound to change in due course
and leading to failure when assumptions about the offsets differ.
Atsushi-San suggested that, it's better to have different version of
eppic scripts, those will be valid for the range of kernel release and
their naming convention hinting, of the release they are valid across.
The first patch renames the existing eppic script to reflect the kernel
<eppic_script>-<valid from kernel version>_to_<valid until kernel version>.c
Rest of three patches creates new eppic scripts to match with the kernel
data structures they work with.

Thank you for reflecting my comments, looks good to me.
v1.6.1 is ready now, these patches will be merged into v1.6.2.

Thanks,
Atsushi Kumagai

eppic: Rename scripts to reflect validity of kernel version
eppic/vhost_net_buffers: Introduce changes for kernel 3.19
eppic/dir_names: Introduce changes for kernel 3.14
eppic/keyring: Introduce changes for kernel 4.4
eppic_scripts/README | 26 +-
eppic_scripts/ap_messages.c | 82 ------
eppic_scripts/ap_messages_3_10_to_4_8.c | 82 ++++++
eppic_scripts/dir_names.c | 78 -----
eppic_scripts/dir_names_3_10_to_3_13.c | 78 +++++
eppic_scripts/dir_names_3_14_to_4_8.c | 82 ++++++
eppic_scripts/keyring.c | 57 ----
eppic_scripts/keyring_3_10_to_4_3.c | 57 ++++
eppic_scripts/keyring_4_4_to_4_8.c | 378 +++++++++++++++++++++++++
eppic_scripts/proc_names.c | 49 ----
eppic_scripts/proc_names_3_10_to_4_8.c | 49 ++++
eppic_scripts/tcp_sk_buf.c | 82 ------
eppic_scripts/tcp_sk_buf_3_10_to_4_8.c | 82 ++++++
eppic_scripts/udp_sk_buf.c | 83 ------
eppic_scripts/udp_sk_buf_3_10_to_4_8.c | 83 ++++++
eppic_scripts/unix_sk_buff.c | 85 ------
eppic_scripts/unix_sk_buff_3_10_to_4_8.c | 85 ++++++
eppic_scripts/vhost_net_buffers.c | 99 -------
eppic_scripts/vhost_net_buffers_3_10_to_3_18.c | 99 +++++++
eppic_scripts/vhost_net_buffers_3_19_to_4_8.c | 104 +++++++
eppic_scripts/vhost_scsi_buffers.c | 75 -----
eppic_scripts/vhost_scsi_buffers_3_10_to_4_8.c | 75 +++++
22 files changed, 1270 insertions(+), 700 deletions(-)
delete mode 100644 eppic_scripts/ap_messages.c
create mode 100644 eppic_scripts/ap_messages_3_10_to_4_8.c
delete mode 100644 eppic_scripts/dir_names.c
create mode 100644 eppic_scripts/dir_names_3_10_to_3_13.c
create mode 100644 eppic_scripts/dir_names_3_14_to_4_8.c
delete mode 100644 eppic_scripts/keyring.c
create mode 100644 eppic_scripts/keyring_3_10_to_4_3.c
create mode 100644 eppic_scripts/keyring_4_4_to_4_8.c
delete mode 100644 eppic_scripts/proc_names.c
create mode 100644 eppic_scripts/proc_names_3_10_to_4_8.c
delete mode 100644 eppic_scripts/tcp_sk_buf.c
create mode 100644 eppic_scripts/tcp_sk_buf_3_10_to_4_8.c
delete mode 100644 eppic_scripts/udp_sk_buf.c
create mode 100644 eppic_scripts/udp_sk_buf_3_10_to_4_8.c
delete mode 100644 eppic_scripts/unix_sk_buff.c
create mode 100644 eppic_scripts/unix_sk_buff_3_10_to_4_8.c
delete mode 100644 eppic_scripts/vhost_net_buffers.c
create mode 100644 eppic_scripts/vhost_net_buffers_3_10_to_3_18.c
create mode 100644 eppic_scripts/vhost_net_buffers_3_19_to_4_8.c
delete mode 100644 eppic_scripts/vhost_scsi_buffers.c
create mode 100644 eppic_scripts/vhost_scsi_buffers_3_10_to_4_8.c
--
2.7.4
_______________________________________________
kexec mailing list
http://lists.infradead.org/mailman/listinfo/kexec

[Kamalesh Babulal]

On Tuesday 27 December 2016 10:52 AM, Atsushi Kumagai wrote:

Hi Atsushi-San,

Post by Atsushi Kumagai

This patch series creates eppic scripts a for range kernel versions
they are compatible with. Eppic scripts directory host sample
scripts to scrub sensitive information from the dump file generated
using makedumpfile.
The initial version of these scripts was based on Fedora 19 kernel.
In brief, these scripts rely on hard coded kernel data structure
member offsets. Kernel data structures are bound to change in due course
and leading to failure when assumptions about the offsets differ.
Atsushi-San suggested that, it's better to have different version of
eppic scripts, those will be valid for the range of kernel release and
their naming convention hinting, of the release they are valid across.
The first patch renames the existing eppic script to reflect the kernel
<eppic_script>-<valid from kernel version>_to_<valid until kernel version>.c
Rest of three patches creates new eppic scripts to match with the kernel
data structures they work with.

Thank you for reflecting my comments, looks good to me.
v1.6.1 is ready now, these patches will be merged into v1.6.2.

Thank you for the reviews and picking them. Happy New Year.